Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent undefined mutation result in useMutation #8018

Merged
merged 2 commits into from
Apr 23, 2021
Merged

Prevent undefined mutation result in useMutation #8018

merged 2 commits into from
Apr 23, 2021

Conversation

jcreighton
Copy link
Contributor

@jcreighton jcreighton commented Apr 22, 2021 •
edited
Loading

Fixes #7754. When an onError handler is provided, the mutation promise returned undefined when it should return a result. We now return a result with data and errors.

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@jcreighton jcreighton force-pushed the 7754-useMutation-onError branch from bde6442 to 6506c61 Compare April 22, 2021 02:48
@jcreighton jcreighton requested review from benjamn and brainkim April 22, 2021 14:05
brainkim
brainkim reviewed Apr 22, 2021
View reviewed changes
Copy link
Contributor

@brainkim brainkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jcreighton jcreighton force-pushed the 7754-useMutation-onError branch from 6506c61 to 4e0ab87 Compare April 22, 2021 18:43
benjamn
benjamn approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@jcreighton jcreighton force-pushed the 7754-useMutation-onError branch from 4e0ab87 to c2a4e84 Compare April 22, 2021 22:59
@jcreighton jcreighton merged commit 9b766ad into main Apr 23, 2021
@jcreighton jcreighton deleted the 7754-useMutation-onError branch April 23, 2021 00:46
@sfratini sfratini mentioned this pull request Jun 17, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brainkim brainkim brainkim left review comments

@benjamn benjamn benjamn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mutation response is undefined, but shouldn't be
3 participants
@jcreighton @benjamn @brainkim